fixes the secret handling #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unglaublicherdude
requested review from
doxthree,
pstadermann and
lennartdohmann
as code owners
unglaublicherdude
force-pushed
the
57-allow-users-to-provide-imagepullsecrets-from-outside-of-the-values
branch
from
aa1c0fd to
003f878
Compare
|
We could take the opportunity here and adapt the Readme.md in this PR to explain how to set the secrets. Isn't the first part of the explanation a bit misleading if you have to set either one or the other and not both? This section |
|
With this PR it is not the case anymore. You can set just one of the two options but also both. And yes, we might come up with a better explanation to that, but maybe we do this afterwards, because a customer is waiting for this PR. |
lennartdohmann
approved these changes
Jun 27, 2024
you either have to configure a dockerjsonconfig or a global.imagepullsecrets but when you configure both, both are added to the imagepullsecrets in the deployments and stateful-sets
unglaublicherdude
force-pushed
the
57-allow-users-to-provide-imagepullsecrets-from-outside-of-the-values
branch
from
7f369a3 to
4136a5b
Compare
pstadermann
approved these changes
Jun 28, 2024
unglaublicherdude
deleted the
57-allow-users-to-provide-imagepullsecrets-from-outside-of-the-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you either have to configure a dockerjsonconfig or a global.imagepullsecrets
but when you configure both, both are added to the imagepullsecrets in the deployments and stateful-sets